fix(platform-browser): add missing peerDependency on `@angular/animat… #35949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions` `@angular/platform-browser/animations` has a dependency on `@angular/animations` however, this is not listed in `peerDependencies` With this change we add this package as an optional peerDependency as it's only required when using the `@angular/platform-browser/animations` entrypoint. Fixes #35888
alan-agius4
added
the
target: patch
alan-agius4
added
the
area: packaging
alan-agius4
requested review from
josephperrott
and removed request for
josephperrott
matsko
pushed a commit
that referenced
this pull request
Mar 10, 2020
…ions` (#35949) `@angular/platform-browser/animations` has a dependency on `@angular/animations` however, this is not listed in `peerDependencies` With this change we add this package as an optional peerDependency as it's only required when using the `@angular/platform-browser/animations` entrypoint. Fixes #35888 PR Close #35949
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions`
@angular/platform-browser/animationshas a dependency on@angular/animationshowever, this is not listed inpeerDependenciesWith this change we add this package as an optional peerDependency as it's only required when using the
@angular/platform-browser/animationsentrypoint.Fixes #35888